fix: handle edge cases in `_tools/eslint/rules/eol-open-bracket-spaci…

…ng` (stdlib-js#4310) PR-URL: stdlib-js#4310 Reviewed-by: Athan Reines <[email protected]>
0PrashantYadav0 · Dec 28, 2024 · 5b30771 · 5b30771
1 parent 9d632d5
commit 5b30771
Show file tree

Hide file tree

Showing 2 changed files with 63 additions and 3 deletions.
diff --git a/lib/node_modules/@stdlib/_tools/eslint/rules/eol-open-bracket-spacing/lib/main.js b/lib/node_modules/@stdlib/_tools/eslint/rules/eol-open-bracket-spacing/lib/main.js
@@ -91,7 +91,10 @@ function main( context ) {
 			) {
 				prevToken = source.getTokenBefore( args[ 0 ] );
 				tokenAfter = source.getFirstToken( args[ 0 ] );
-				if ( source.isSpaceBetween( prevToken, tokenAfter ) ) {
+				if (
+					prevToken.loc.end.line === tokenAfter.loc.end.line &&
+					source.isSpaceBetween( prevToken, tokenAfter )
+				) {
 					report( node, prevToken, tokenAfter );
 				}
 			} else if ( args[ 0 ].type === 'ArrayExpression' ) {
@@ -102,7 +105,10 @@ function main( context ) {
 				) {
 					prevToken = source.getTokenBefore( args[ 0 ] );
 					tokenAfter = source.getFirstToken( args[ 0 ] );
-					if ( source.isSpaceBetween( prevToken, tokenAfter ) ) {
+					if (
+						prevToken.loc.end.line === tokenAfter.loc.end.line &&
+						source.isSpaceBetween( prevToken, tokenAfter )
+					) {
 						report( node, prevToken, tokenAfter );
 					}
 				} else {
@@ -111,6 +117,7 @@ function main( context ) {
 					nextToken = source.getTokenAfter( tokenAfter );
 					if (
 						tokenAfter.loc.end.line !== nextToken.loc.end.line &&
+						prevToken.loc.end.line === tokenAfter.loc.end.line &&
 						source.isSpaceBetween( prevToken, tokenAfter )
 					) {
 						report( node, prevToken, tokenAfter );
@@ -131,7 +138,10 @@ function main( context ) {
 				prevToken = source.getFirstToken( node );
 				tokenAfter = source.getFirstToken( elem );
 
-				if ( source.isSpaceBetween( prevToken, tokenAfter ) ) {
+				if (
+					prevToken.loc.end.line === tokenAfter.loc.end.line &&
+					source.isSpaceBetween( prevToken, tokenAfter )
+				) {
 					report( node, prevToken, tokenAfter );
 				}
 			}

diff --git a/...modules/@stdlib/_tools/eslint/rules/eol-open-bracket-spacing/test/fixtures/unvalidated.js b/...modules/@stdlib/_tools/eslint/rules/eol-open-bracket-spacing/test/fixtures/unvalidated.js
@@ -50,6 +50,56 @@ test = {
 };
 valid.push( test);
 
+test = {
+	'code': [
+		'  var log = require( \'@stdlib/console/log\' );',
+		'  log(',
+		'    {',
+		'      \'a\': 1',
+		'    }',
+		'  );'
+	].join( '\n' )
+};
+valid.push( test);
+
+test = {
+	'code': [
+		'  var log = require( \'@stdlib/console/log\' );',
+		'  log(',
+		'    [',
+		'      1,',
+		'      2',
+		'    ]',
+		'  );'
+	].join( '\n' )
+};
+valid.push( test);
+
+test = {
+	'code': [
+		'  var log = require( \'@stdlib/console/log\' );',
+		'  log(',
+		'    [',
+		'      {',
+		'        \'a\': 1',
+		'      }',
+		'    ]',
+		'  );'
+	].join( '\n' )
+};
+valid.push( test);
+
+test = {
+	'code': [
+		'  var arr = [',
+		'  {',
+		'    \'a\': 1',
+		'  }',
+		'];'
+	].join( '\n' )
+};
+valid.push( test);
+
 
 // EXPORTS //