-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@peter/integration test #21
Conversation
aa806d0
to
fecd65d
Compare
8e0991e
to
524b8f7
Compare
524b8f7
to
ff64ae7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 10 files at r1, 16 of 16 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @0g-peterzhb)
tests/da_test_framework/da_encoder.py
line 50 at r2 (raw file):
def wait_for_rpc_connection(self): time.sleep(3)
Is it possible to call some RPC method here to check if the RPC service has started?
tests/da_test_framework/da_server.py
line 56 at r2 (raw file):
time.sleep(3) self.log.info(f'{self.grpc_url}') self.channel = grpc.insecure_channel(self.grpc_url)
same here
Why are these changes needed?
Checks
This change is