Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@peter/integration test #21

Merged
merged 11 commits into from
Mar 22, 2024
Merged

@peter/integration test #21

merged 11 commits into from
Mar 22, 2024

Conversation

0g-peterzhb
Copy link
Contributor

@0g-peterzhb 0g-peterzhb commented Mar 19, 2024

Why are these changes needed?

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

This change is Reviewable

.gitmodules Outdated Show resolved Hide resolved
@0g-peterzhb 0g-peterzhb force-pushed the @peter/integration-test branch 4 times, most recently from aa806d0 to fecd65d Compare March 22, 2024 03:10
@0g-peterzhb 0g-peterzhb force-pushed the @peter/integration-test branch 2 times, most recently from 8e0991e to 524b8f7 Compare March 22, 2024 03:13
@0g-peterzhb 0g-peterzhb force-pushed the @peter/integration-test branch from 524b8f7 to ff64ae7 Compare March 22, 2024 03:16
Copy link

@peilun-conflux peilun-conflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 10 files at r1, 16 of 16 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @0g-peterzhb)


tests/da_test_framework/da_encoder.py line 50 at r2 (raw file):

    def wait_for_rpc_connection(self):
        time.sleep(3)

Is it possible to call some RPC method here to check if the RPC service has started?


tests/da_test_framework/da_server.py line 56 at r2 (raw file):

            time.sleep(3)
        self.log.info(f'{self.grpc_url}')
        self.channel = grpc.insecure_channel(self.grpc_url)

same here

@0g-peterzhb 0g-peterzhb merged commit 371271d into main Mar 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants