refactor: data fee #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0g-peterzhb
approved these changes
Jul 31, 2024
| var fee *big.Int | ||
| if kvWriteArgs.fee > 0 { | ||
| feeInA0GI := big.NewFloat(kvWriteArgs.fee) | ||
| fee, _ = feeInA0GI.Mul(feeInA0GI, big.NewFloat(1e18)).Int(nil) |
There was a problem hiding this comment.
how about let users to convert this and we only accept neuron?
There was a problem hiding this comment.
not sure, it might require the user to input a number that is a dozen digits long
boqiu
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @0g-peterzhb)
cmd/kv_write.go line 107 at r1 (raw file):
Previously, MiniFrenchBread wrote…
not sure, it might require the user to input a number that is a dozen digits long
As a user, I prefer to use A0GI as fee unit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketcontract dynamically--feefor related CLIThis change is