Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): Export types in output typings file separately for composite projects #350

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Jul 29, 2024

Resolves #348

Summary

Not exporting types separately in composite projects seems to cause a serialization diagnostic error. This seems to be a bug in TypeScript but worked around quite easily.

Set of changes

  • Output separate introspection_types export for pre-processed .d.ts typings output file unless preprocessing is disabled

@kitten kitten requested a review from JoviDeCroock July 29, 2024 10:41
Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 2b8ff7c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten merged commit f9c9861 into main Jul 29, 2024
2 checks passed
@kitten kitten deleted the fix/composite-serialization-error branch July 29, 2024 10:46
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexported types cause TS7056
2 participants