Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: break down stages into starlark packages #30

Merged
merged 31 commits into from
Mar 27, 2024
Merged

refactor: break down stages into starlark packages #30

merged 31 commits into from
Mar 27, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Mar 26, 2024 •
edited
Loading

  • Break down stages into Starlark packages.
  • Implement stages with booleans instead of an integer array for greater clarity.
  • Test both monolithic and incremental approaches in CI.
  • Remove some of the parameters in params.yml and move them to the templates, closer to the configuration files.

@leovct leovct marked this pull request as ready for review March 27, 2024 10:11
praetoriansentry
praetoriansentry approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@praetoriansentry praetoriansentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz fix the minor bridge ui issue, but otherwise let's merge

@leovct leovct merged commit d96aa86 into main Mar 27, 2024
4 checks passed
@leovct leovct deleted the refactor/stages-2 branch March 27, 2024 16:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@leovct leovct mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praetoriansentry praetoriansentry praetoriansentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leovct @praetoriansentry