Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pessimistic Proof Integration and Features #401

Merged
merged 47 commits into from
Jan 7, 2025
Merged

Pessimistic Proof Integration and Features #401

merged 47 commits into from
Jan 7, 2025

Conversation

praetoriansentry
Copy link
Member

@praetoriansentry praetoriansentry commented Nov 27, 2024 •
edited
Loading

Description

This PR has some of the changes made to support pessmistic proof networks more generally:

  • Added a configuration file for the attachment of a second pessmistic chain
  • Reverted to older versions of the agglayer for fork 11 and fork 9 tests
  • Deactivating the CDK based tests until we have a simpler decoupled approach
  • Testing procedure documented in docs/multi-pp-testing/README.md
  • Adding a doc related to intercepting traffic with mitmproxy
  • Bridge Service config changes to simplify testing
  • Adding the vkey to the create_rollup_parameters

praetoriansentry and others added 30 commits November 27, 2024 15:21
@praetoriansentry
feat: adding support for vkey config
cf27b23
@praetoriansentry
docs: adding some guidance for testing
060f6a9
@praetoriansentry
Merge branch 'main' into jhilliard/multi-pp-testing
b548f1b
@praetoriansentry
Merge branch 'main' into jhilliard/multi-pp-testing
98bb78e
@praetoriansentry
chore: version bump
d5c0b61
@praetoriansentry
fix: vkey
bf90e63
@praetoriansentry
feat: latest changes for testing
432a372
@praetoriansentry
Merge branch 'main' into jhilliard/multi-pp-testing
d59c916
@praetoriansentry
feat: version difference and configs
14ff92c
@praetoriansentry
chore: version bump
1422668
@praetoriansentry
chore: bridge version bump
682aef7
@praetoriansentry
chore: minore config changes
a54f136
@praetoriansentry
docs: updating
c5058b8
@praetoriansentry
Merge branch 'main' into jhilliard/multi-pp-testing
1f5e20a
@praetoriansentry
chore: version bump and adding reference rate limit
349a515
@praetoriansentry
chore: wip docs
9ddebd3
@praetoriansentry
doc: litdown
d44d726
@praetoriansentry
docs: latest tests
ec8cae5
@praetoriansentry
wip: testing notes
7360cd1
@praetoriansentry
docs: latest testing procedures
1dca419
@praetoriansentry
feat: latest testing notes
ada28e0
@praetoriansentry
chore: moving docs
a4d18b2
@joanestebanr
feat: add RPC port to cdk-node
1240275
@praetoriansentry
Merge pull request #427 from 0xPolygon/jesteban/add_port_cdk_node
a7a8df5 
feat: add RPC port to cdk-node
@praetoriansentry
feat: wip docs
dbcb1d7
@praetoriansentry
Merge remote-tracking branch 'refs/remotes/origin/jhilliard/multi-pp-…
9a69211 
…testing' into jhilliard/multi-pp-testing
@praetoriansentry
fix: adding no wait for rpc port
355de58
@praetoriansentry
Merge branch 'main' into jhilliard/multi-pp-testing
92f1ff6
@praetoriansentry
lint: removing .sh extension
d2ce23a
@praetoriansentry
chore: deleteing unused function
539cb72
@praetoriansentry praetoriansentry changed the title (Do Not Merge) Multi-Network PP Testing Pessimistic Proof Integration and Features Jan 6, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@praetoriansentry praetoriansentry marked this pull request as ready for review January 6, 2025 18:01
leovct
leovct approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! It's well documented and easy to follow, thank you.

.github/tests/forks/fork11.yml Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
templates/contract-deploy/run-contract-setup.sh Show resolved Hide resolved
docs/multi-pp-testing/README Show resolved Hide resolved
docs/multi-pp-testing/README.md Show resolved Hide resolved
docs/multi-pp-testing/README.md Show resolved Hide resolved
@praetoriansentry praetoriansentry merged commit 83b9224 into main Jan 7, 2025
31 checks passed
@praetoriansentry praetoriansentry deleted the jhilliard/multi-pp-testing branch January 7, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovct leovct leovct approved these changes

@jhkimqd jhkimqd Awaiting requested review from jhkimqd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praetoriansentry @leovct @joanestebanr