Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

fix: fix compilation with test_only feature #84

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented May 28, 2024

address oversight from #78

@Nashtare Nashtare requested review from cpubot and muursh as code owners May 28, 2024 17:27
@Nashtare
Copy link
Collaborator Author

cc @muursh @cpubot I've added a distinct job to run the simple_test.sh script with test_only feature so that this doesn't happen anymore. Would need you to update the branch requirements to have these new jobs required (changed the name of the previous one for clarity).

Copy link
Contributor

@0xaatif 0xaatif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@muursh
Copy link
Contributor

muursh commented May 28, 2024

cc @muursh @cpubot I've added a distinct job to run the simple_test.sh script with test_only feature so that this doesn't happen anymore. Would need you to update the branch requirements to have these new jobs required (changed the name of the previous one for clarity).

Can you not do it? If not I'll work on you having access

@Nashtare
Copy link
Collaborator Author

I don't have access to zero-bin's settings. Only zk_evm, not even plonky2.

@Nashtare Nashtare merged commit 578997a into develop May 28, 2024
4 checks passed
@Nashtare Nashtare deleted the fix/test_only_feature branch May 28, 2024 17:57
@cpubot
Copy link
Contributor

cpubot commented May 28, 2024

I don't have access to zero-bin's settings. Only zk_evm, not even plonky2.

I also don't have access

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants