This repository has been archived by the owner on Nov 8, 2021. It is now read-only.
Support TwitchEmote's v4 API, BTTV v3 API, upgrade deps #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also it tries to test against `channel` instead of `channel_name`
Also fixed the html template.
mkody
changed the title
|
I think the lib is abandoned. Maybe you can upload the lib as another package? |
|
I could look into that but in the meantime you can install from git which works well. |
|
@mkody May I adopt your fork as maintainer and upload to NPM? It would be very beneficial to other developers working with Twitch emotes on their sites. |
|
I went and did it: https://www.npmjs.com/package/@mkody/twitch-emoticons |
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.20) Signed-off-by: dependabot[bot] <[email protected]>
The latter now makes it easier to just use the Twitch ID for everything.
Bumps [eslint](https://github.com/eslint/eslint) from 7.18.0 to 7.25.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.18.0...v7.25.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I hope this is all we need to fix typings actually.
Bumps [got](https://github.com/sindresorhus/got) from 11.8.3 to 11.8.5. - [Release notes](https://github.com/sindresorhus/got/releases) - [Commits](sindresorhus/got@v11.8.3...v11.8.5) --- updated-dependencies: - dependency-name: got dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Close Support Twitch animated icons #17
And update JSDoc types, typings 7TV issue: #15
Also bump deps
Related issue: #15
And update typings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
This PR needs to be updated to drop TwitchEmote altogether as its API doesn't work anymore.
My fork now uses the Twitch API directly, instead.
Since this repo appears abandoned, I've published a package from my
forkbranch: @mkody/twitch-emoticonsThe TwitchEmote v3 API got shut down. Same for BTTV v2.
I pretty much reused bits from the BTTV part for this.
Oh and also fixed the quotes in the html template.
BREAKING CHANGES:
fetchTwitchEmotestakes the ID of the channel as a parameter instead of a string or array of strings with the channel name.BREAKING CHANGES 2:
fetchBTTVEmotestakes the ID of the channel as a parameter instead of a string of the channel name.You should also use a Twitch ID for FFZ, but support for both is still available for now.
Some dependencies and dev-dependencies were updated too.