Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default connect.serviceType to ClusterIP #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: default connect.serviceType to ClusterIP #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/connect/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ helm install --set connect.applicationName=connect connect ./connect
| connect.labels | object | `{}` | Additional labels to be added to the Connect API deployment resource. |
| connect.podAnnotations | object | `{}` | Additional annotations to be added to the Connect API pods. |
| connect.podLabels | object | `{}` | Additional labels to be added to the Connect API pods. |
| connect.serviceType | string | `NodePort` | The type of Service resource to create for the Connect API and sync services. |
| connect.serviceType | string | `ClusterIP` | The type of Service resource to create for the Connect API and sync services. |
| connect.serviceAnnotations | object | `{}` | Additional annotations to be added to the service. |
| connect.sync.imageRepository | string | `"1password/connect-sync"` | The 1Password Connect Sync repository |
| connect.sync.name | string | `"connect-sync"` | The name of the 1Password Connect Sync container |
Expand Down
4 changes: 2 additions & 2 deletions charts/connect/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ connect:

# The type of Service resource to create for the Connect API and sync services.
# See: https://kubernetes.io/docs/concepts/services-networking/service
# This by default is NodePort and can also be defined as LoadBalancer.
# This by default is ClusterIP and can also be defined as NodePort or LoadBalancer.
# If serviceType is LoadBalancer then loadBalancerSourceRanges and loadBalancerIP should be defined.
# See: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer
serviceType: NodePort
serviceType: ClusterIP

# Additional annotations to be added to the service resource
serviceAnnotations: {}
Expand Down
Loading