-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/timeout #102
Fix/timeout #102
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 76.60% 76.96% +0.36%
==========================================
Files 27 27
Lines 1949 1980 +31
==========================================
+ Hits 1493 1524 +31
Misses 456 456 ☔ View full report in Codecov by Sentry. |
Thanks for fixing this @volodymyrZotov, I've created a PR as well fixing this but you was faster than me. |
Fell free to close my PR in favor of yours. |
@raphapassini No worries! I also missed that when tested it. Thanks for the attempt to fix it! That looks like the right approach. But I lean toward merging this one as it also covers edge cases like setting |
… var has negative number
This PR fixes the issue when Client throws an error if
OP_CONNECT_CLIENT_REQ_TIMEOUT
env var is not set.In addition
get_timeout
function is improved to cover the following cases:export OP_CONNECT_CLIENT_REQ_TIMEOUT=None
- it disables all the timeouts (behaves the same as described in to documentation)export OP_CONNECT_CLIENT_REQ_TIMEOUT=''
- it sets default timeout 5s.export OP_CONNECT_CLIENT_REQ_TIMEOUT=0
-it sets default timeout 5s.Testing steps
The env var is set
main.py
fileexport OP_CONNECT_CLIENT_REQ_TIMEOUT=30
python main.py
Should use default timeout
main.py
filepython main.py
Resolves #104