Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum supported Python version from 3.8 to 3.9 #116

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

michaelAbon1p
Copy link
Contributor

  1. I edited the python version in the pyproject.toml file by hand, then ran poetry lock --no-update to generate a few changes as possible in the poetry.lock file.
  2. I also updated the GitHub workflows.

Fixes #115

Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@edif2008 edif2008 mentioned this pull request Dec 19, 2024
edif2008 added a commit that referenced this pull request Dec 19, 2024
Currently no PRs can be merged since the codecov step doesn't work anymore. Fixing that is a lengthy process, so to temporarily unblock important PRs from being merged (i.e. #116, #114, #107), we will remove this from our pipeline.
Currently no PRs can be merged since the codecov step doesn't work anymore. Fixing that is a lengthy process, so to temporarily unblock important PRs from being merged (i.e. #116, #114, #107), we will remove this from our pipeline.
@edif2008 edif2008 merged commit 8871fe0 into 1Password:main Dec 19, 2024
2 checks passed
@michaelAbon1p michaelAbon1p deleted the bump-python-3.9 branch January 8, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python v3.8 is EOL. Bump minimum supported version to v3.9
2 participants