Add Shopify CLI plugin #397
Conversation
| return schema.CredentialType{ | ||
| Name: credname.CLIToken, | ||
| DocsURL: sdk.URL("https://shopify.dev/docs/apps/tools/cli/ci-cd#step-2-generate-a-cli-authentication-token"), | ||
| ManagementURL: sdk.URL("https://partners.shopify.com/"), |
There was a problem hiding this comment.
For the management URL, the intention is to have a URL that would direct the user, if signed in, to a page where they can create a new credential for the service. This looks to be a marketing page instead, is there another link that we can use here?
| func CLIToken() schema.CredentialType { | ||
| return schema.CredentialType{ | ||
| Name: credname.CLIToken, | ||
| DocsURL: sdk.URL("https://shopify.dev/docs/apps/tools/cli/ci-cd#step-2-generate-a-cli-authentication-token"), |
There was a problem hiding this comment.
Let's use https://shopify.dev/docs/apps/tools/cli/ here
| var defaultEnvVarMapping = map[string]sdk.FieldName{ | ||
| "SHOPIFY_TOKEN": fieldname.Token, | ||
| } |
There was a problem hiding this comment.
Can you please provide some docs on SHOPIFY_TOKEN? I haven't been able to find this envvar anywhere in the docs.
| )} | ||
| } | ||
|
|
||
| var defaultEnvVarMapping = map[string]sdk.FieldName{ |
There was a problem hiding this comment.
Question: From this page
https://shopify.dev/docs/apps/tools/cli/ci-cd#step-2-generate-a-cli-authentication-token
It looks like SHOPIFY_API_KEY may also be a requirement? Not sure if the local use-case of the CLI is different than CI/CD.
Overview
Adding a shell-plugin for the Shopify CLI.
Type of change
Related Issue(s)
How To Test
shopify theme devChangelog
Adds the Shopify CLI plugin.