Add support for Prepending args in the File Provisioner #508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enhanced the
sdk.ProvisionOutput
to support flexible argument placement with new methods:AddArgsAtIndex
,PrependArgs
, andAppendArgs
.Subsequently then used these functions in the
sdk.Provision
module to replaceAddArgs
withPrependArgs
andAppendArgs
in the file provisioner for better control of argument placement.Subsequently updated the following modules where
AddArgs
was used to useAppendArgs
to maintain existing functionality.Type of change
Related Issue(s)
How To Test
Pass either of the new provision.FileOption implementations (PrependArgs or AppendArgs) to a provision.FileProvisioner instance. Both the akamai and mysql plugins currently utilise this provisioner and can be updated with minimal changes to verify the behaviour.
For example, test the mysql plugin’s DatabaseCredentials provisioner as follows:
To test different behaviors, modify the FileOption used in the plugin’s default provisioner:
Changelog
Introduce
PrependArgs
andAppendArgs
for precise command-line argument placement in file provisioners.