Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make QGIS Server 3.34 for testing in LWC 3.8 #4367

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Apr 15, 2024

While #4323 is only targeting tests, I'm wondering about raising QGIS server min to 3.34 to the minimum required version for 3.8.

I know we got some discussions on 3.7 to limit to 3.22, because of some dependencies on Ubuntu 22.04 or similar.

But now, LWC 3.7 relies a lot the JSON legend from QGIS Server :

  • this JSON legend is "quite" new in the QGIS server implementation
  • There are a few bugfix on QGIS server about this JSON legend and it can only be backported to 3.34 minimum now. So for the quality of the project and related to bug reports, it would make sense to have latest bugfix from QGIS server about the legend.
  • We don't have 3.28 anymore most of Ubuntu users because of APT, so therefore generating some 3.34 projects. This is a problem
  • 3.28 is already not maintained (but on the other side, we can see it as an "stable" 3.28 now as well)

Open to discuss

@mdouchin @rldhont @nboisteault @mind84 @gioman @josemvm

@Gustry Gustry added the run end2end If the PR must run end2end tests or not label Apr 15, 2024
@github-actions github-actions bot added this to the 3.8.0 milestone Apr 15, 2024
@mdouchin
Copy link
Collaborator

+1 for me

@nboisteault nboisteault self-requested a review April 22, 2024 14:13
@Gustry
Copy link
Member Author

Gustry commented Apr 22, 2024

They are also other PR targeting QGIS 3.34 minimum, for instance qgis/QGIS#57219 about project speed, not only the JSON legend.

It will be more robust for LWC to have an update to date version of QGIS server.

CC @guenterw as well or other Lizmap users ?

@guenterw
Copy link

Many thanks for the information. It is understandable that future versions of Lizmap should be based on the latest possible QGIS server versions. And at some point, an upgrade to Ubuntu 22.04 or a new server is due.

However, my observation is that Lizmap 3.7 and 3.8 is slower than Lizmap 3.6, even with QGIS Server 3.34. and that especially in the legend the loading of the layers (rotating circle) is not displayed correctly.
I have carried out test projects with the same QGIS project for:
https://cx21-6.webgis.biz Lizmap 3.6.11
https://cx21-7.webgis.biz Lizmap 3.7.6
https://cx21-8.webgis.biz Lizmap 3.8.0 Alpha.1

With QGIS-Server/Desktop 3.34.6, Lizmap-Plugin 4.3.6
The server is quite slow (small cloud server for testing)

@nboisteault
Copy link
Member

@guenterw I used lighthouse with your Lizmap 3.6, performance score is 35/100. With 3.8, performance score is 40/100. Those performance score could be way better with right server configuration as enabling http2 for example. But anyway 3.8 score is best.

@guenterw
Copy link

@nboisteault Thank you very much. It is very interesting that the subjective perception of speed is quite different. Version 3.7 and 3.8 simply don't load as smoothly subjectively. This is also the observation of other users and my customers.
I will test the use of http2.

@guenterw
Copy link

Sorry, this is not really part of the topic but it is very important for me to use the new versions.

I have now activated http2 but this does not bring any change. The measurements with lighthouse fluctuate a lot and give a completely different picture than the normal test in the browser.
So I preferred to stop the speed with the watch. Several times, each time clearing the browser cache.
It is interesting that there are big differences between the PC (older i5 Win10), the notebook (newer i7 Win10) and mobile devices (Samsung tablet).
In each case from the start of the project (Bauleitplanung),
image

immediately zoomed to a maximum scale of 1:250 (PC and notebook with mouse scroll wheel):

https://cx21-6.webgis.biz/ Lizmap 3.6.11: PC 10 sec., NB 5 sec. Mobile < 5 sec.
https://cx21-7.webgis.biz/ Lizmap 3.7.6: PC 30 sec., NB 16 sec., Mobile 10-15 sec.
https://cx21-8.webgis.biz/ Lizmap 3.8.0 Alpha.1 PC 54 sec., NB 26 sec., Mobile 10-15 sec.

How can we explain these differences?
And version 3.6 is always significantly faster in all tests

With versions 3.7 and 3.8 you sit in front of a white screen for a long time (especially on the PC)
image

@nboisteault
Copy link
Member

@guenterw please open a new ticket for this issue.

@Gustry
Copy link
Member Author

Gustry commented May 7, 2024

After some discussion with @rldhont I will revert the part that makes QGIS Server 3.34 required. It will be 3.28.
However, people will be encouraged to migrate to QGIS Server 3.34, because for instance bugfix can only land on the current maintained branch by QGIS, so 3.34 (JSON legend etc)

We are only talking about QGIS Server version.
A follow up PR will be about QGIS Desktop.

@Gustry Gustry changed the title Make QGIS Server 3.34 minimum for LWC 3.8 Make QGIS Server 3.34 for testing in LWC 3.8 May 13, 2024
@Gustry Gustry modified the milestones: 3.8.0, 3.9.0 Jun 7, 2024
@Gustry
Copy link
Member Author

Gustry commented Jun 13, 2024

Temporary cherry-picked PR #4516 to test on QGIS Server 3.34 @rldhont

Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jun 24, 2024
Copy link

github-actions bot commented Jul 1, 2024

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added the stale This ticket might be closed soon label Jul 1, 2024
@Gustry Gustry removed the stale This ticket might be closed soon label Jul 2, 2024
@Gustry
Copy link
Member Author

Gustry commented Jul 2, 2024

E2E tests have been temporary disabled about the default background color.

@Gustry Gustry merged commit 12e4860 into 3liz:master Jul 2, 2024
13 checks passed
@Gustry Gustry deleted the min-qgis-34 branch July 2, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_8 run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants