-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make QGIS Server 3.34 for testing in LWC 3.8 #4367
Conversation
+1 for me |
They are also other PR targeting QGIS 3.34 minimum, for instance qgis/QGIS#57219 about project speed, not only the JSON legend. It will be more robust for LWC to have an update to date version of QGIS server. CC @guenterw as well or other Lizmap users ? |
Many thanks for the information. It is understandable that future versions of Lizmap should be based on the latest possible QGIS server versions. And at some point, an upgrade to Ubuntu 22.04 or a new server is due. However, my observation is that Lizmap 3.7 and 3.8 is slower than Lizmap 3.6, even with QGIS Server 3.34. and that especially in the legend the loading of the layers (rotating circle) is not displayed correctly. With QGIS-Server/Desktop 3.34.6, Lizmap-Plugin 4.3.6 |
@guenterw I used lighthouse with your Lizmap 3.6, performance score is 35/100. With 3.8, performance score is 40/100. Those performance score could be way better with right server configuration as enabling http2 for example. But anyway 3.8 score is best. |
@nboisteault Thank you very much. It is very interesting that the subjective perception of speed is quite different. Version 3.7 and 3.8 simply don't load as smoothly subjectively. This is also the observation of other users and my customers. |
Sorry, this is not really part of the topic but it is very important for me to use the new versions. I have now activated http2 but this does not bring any change. The measurements with lighthouse fluctuate a lot and give a completely different picture than the normal test in the browser. immediately zoomed to a maximum scale of 1:250 (PC and notebook with mouse scroll wheel): https://cx21-6.webgis.biz/ Lizmap 3.6.11: PC 10 sec., NB 5 sec. Mobile < 5 sec. How can we explain these differences? With versions 3.7 and 3.8 you sit in front of a white screen for a long time (especially on the PC) |
@guenterw please open a new ticket for this issue. |
3d89af9
to
f093f5b
Compare
After some discussion with @rldhont I will revert the part that makes QGIS Server 3.34 required. It will be 3.28. We are only talking about QGIS Server version. |
238a00c
to
4ef2caf
Compare
The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale". |
The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale". |
E2E tests have been temporary disabled about the default background color. |
While #4323 is only targeting tests, I'm wondering about raising QGIS server min to 3.34 to the minimum required version for 3.8.
I know we got some discussions on 3.7 to limit to 3.22, because of some dependencies on Ubuntu 22.04 or similar.
But now, LWC 3.7 relies a lot the JSON legend from QGIS Server :
Open to discuss
@mdouchin @rldhont @nboisteault @mind84 @gioman @josemvm