-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Add Popup dock server side #4398
Conversation
fc5f2f5
to
0d7e2b5
Compare
I have this error on ReferenceError: lizUrls is not defined <script id="lizmap-vars" type="application/json">{"lizUrls":{"params":{"repository":"testsrepository","project":"attribute_table"},"config":"\/index.php\/lizmap\/service\/getProjectConfig","remoteStorageConfig":"\/index.php\/lizmap\/service\/getRemoteStorageConfig","keyValueConfig":"\/index.php\/lizmap\/service\/getKeyValueConfig","wms":"\/index.php\/lizmap\/service","media":"\/index.php\/view\/media\/getMedia","nominatim":"\/index.php\/lizmap\/osm\/nominatim","ign":"\/index.php\/lizmap\/ign\/address","edition":"\/index.php\/lizmap\/edition\/getFeature","permalink":"http:\/\/localhost:8130\/index.php\/view\/map","dataTableLanguage":"\/assets\/js\/dataTables\/fr_FR.json","basepath":"\/","geobookmark":"\/index.php\/lizmap\/geobookmark","service":"\/index.php\/lizmap\/service?repository=testsrepository&project=attribute_table","resourceUrlReplacement":{"webdav":"dav\/"},"webDavUrl":"http:\/\/webdav\/"},"lizProj4":{"EPSG:2154":"+proj=lcc +lat_0=46.5 +lon_0=3 +lat_1=49 +lat_2=44 +x_0=700000 +y_0=6600000 +ellps=GRS80 +towgs84=0,0,0,0,0,0,0 +units=m +no_defs","EPSG:4326":"+proj=longlat +datum=WGS84 +no_defs","":""},"filterConfigData":{"url":"\/index.php\/filter\/service?repository=testsrepository&project=attribute_table"},"filterConfig":{}}</script> |
The popup dock is build client side by the JS and depends on `lizDict`. Since 3liz#4329 the popup dock could be created before the `lizDict` is available.
0d7e2b5
to
327ae66
Compare
It seems ok this morning restarting my docker stack... I had to |
@mdouchin @nboisteault ready for review. backport or not ? |
backport to 3.7 would be great |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-4398-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 327ae66d0219ad799dd17e9f2553db55e874f7ec
# Push it to GitHub
git push --set-upstream origin backport-4398-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7 Then, create a pull request where the |
The popup dock is build client side by the JS and depends on
lizDict
. Since #4329 the popup dock could be created before thelizDict
is available.