-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] JS config themes #4514
Conversation
hi @rldhont i get this error maybe related to this PR (?) |
When you've got this message, it means that one of the GetCapabilities requests (WMS, WFS, WMTS) or all has failed. |
Please check your Javascript console, you will have some tips about what was wrong, in the "Console" and/or in the "Network" tab by checking which requests as failed. |
in the network tab everything looks good to me but i can provide an url if you want to investigate thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to review too much this PR, but given the fact it fixes tests on QGIS 3.34, LGTM.
You will have some conflicts while backporting, at least on 3.7 I think.
I think it's a blocker for releasing 3.7 and 3.8 this PR.
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-4514-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 269a2dcd572458bfcc9b7f2e825254f325c265f2,f9833ae079d7fd8d4a8f44815ac2f3141d2aa476,f345e3a8d26f87da80bdcbd73fa97cc58569c503,03f35fd8422f36f98342766b9e06dce4419d39ae,97cdaa30ded7a67b265f28e6b44e902ed919d586,ff9dfd1c6401d3977ef9a1ce1b96387987611d79
# Push it to GitHub
git push --set-upstream origin backport-4514-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7 Then, create a pull request where the |
Fixing JS classes around map themes
Funded by Karum