Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic permalink will be disabled by default #4591

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Jul 8, 2024

After #4586 that added automatic_permalink option the default value will be false.

@rldhont rldhont added user interface tests unit tests and docker configuration for tests javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not backport release_3_8 labels Jul 8, 2024
@github-actions github-actions bot added this to the 3.9.0 milestone Jul 8, 2024
After 3liz#4586 that added `automatic_permalink` option
the default value will be false.
@rldhont rldhont force-pushed the fix-disable-automatic-permalink branch from 562e137 to 613453d Compare July 9, 2024 08:06
@rldhont rldhont requested review from Gustry and nboisteault July 9, 2024 08:36
@rldhont
Copy link
Collaborator Author

rldhont commented Jul 9, 2024

@Gustry the PR is ready.

Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rldhont rldhont merged commit e2bb302 into 3liz:master Jul 9, 2024
13 checks passed
@rldhont rldhont deleted the fix-disable-automatic-permalink branch July 9, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_8 javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants