JS: Enhancing digitizing component and module #4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rldhont
commented
Jul 10, 2024
rldhont
commented
- Add erase all button and method
- Removed from localstorage when saved is toggled
- Add a measure attribute to enable or not the measure button
- Fix locale key confirm erase by replacing confirme by confirm
rldhont
added
user interface
javascript
Gustry
reviewed
Jul 15, 2024
rldhont
force-pushed
the
fix-digitizing
branch
2 times, most recently
from
6e2837c to
de4b653
Compare
|
@Gustry @nboisteault it is ready for review |
To enable measure with digitizing component, the attribute measure has to be added.
Add a new button to erase all digitizing features in the digitizing component, and the method in the digitizing module.
Replace `digitizing.confirme.erase` by `digitizing.confirm.erase`
Now when the saved is toggle the browser localstorage is clear. When the user click on digitizing saved button, a message is displayed to explain that the drawing changes wil be saved in the browser, and the digitizing save title changed to explain that the drawing will be removed from the browser.
* Test erase all * Check toggle save
nboisteault
reviewed
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.