Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - Add raster embed layer in child project #4857

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Oct 9, 2024

Tests - Add raster embed layer in child project
It works in the parent project, but not in the child project.

Linked to issue #3954 #4169

CC @arno974

@Gustry Gustry added run end2end If the PR must run end2end tests or not backport release_3_7 backport release_3_8 labels Oct 9, 2024
@github-actions github-actions bot added this to the 3.9.0 milestone Oct 9, 2024
@arno974
Copy link

arno974 commented Oct 9, 2024

I've checked your embed_child project and it does not contains the "Plan IGN" layers from the parent project (embed_parents). I've added the "Plan IGN" layers in my embed_child project and then opened this project in the Lizmap web client. The IGN layer (which contains spaces in its name) does not display in the child project in lizmap web client.

@Gustry
Copy link
Member Author

Gustry commented Oct 9, 2024

Thanks @arno974 for testing this PR.

It helps a lot when the test data is already included in the LWC repository, to replicate the issue indeed. I have updated the project with the "IGN plan" layer

@Gustry
Copy link
Member Author

Gustry commented Oct 9, 2024

Note the accent and space was with the other layer r@stér fîlê ;-)

@Gustry Gustry merged commit 8113eee into 3liz:master Oct 9, 2024
13 checks passed
@Gustry Gustry deleted the embed-raster branch October 9, 2024 07:49
nboisteault pushed a commit to nboisteault/lizmap-web-client that referenced this pull request Dec 12, 2024
Tests - Add raster embed layer in child project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_7 backport release_3_8 run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants