[Bugfix] Trully stream data from iterable #5134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rldhont
added
run end2end
`GuzzleHttp\Psr7\Utils::streamFor` is building a PumpStream for callable resource and requested the resource with and length to building the data as string step by step. Because, lizmap builds a stream with a function without the length parameter, all the content is build as string before sending it to output. Try to fix it, by providing a function with the length parameter around our iterator.
rldhont
force-pushed
the
fix-ogcresponse-really-stream-data
branch
from
dbd07d2 to
3f63e38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GuzzleHttp\Psr7\Utils::streamForis building a PumpStream for callable resource and requested the resource with and length to building the data as string step by step.Because, lizmap builds a stream with a function without the length parameter, all the content is build as string before sending it to output.
Try to fix it, by providing a function with the length parameter around our iterator.