Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error log panel in admin #5182

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add error log panel in admin #5182

merged 1 commit into from
Jan 15, 2025

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Jan 13, 2025

Logs are important, this panel should be more advertised and used. Some upgrades should be done, in this PR and later.

Some review on the log panel :

@github-actions github-actions bot added this to the 3.10.0 milestone Jan 13, 2025
@Gustry Gustry force-pushed the admin-log branch 2 times, most recently from 62792a2 to e79f931 Compare January 13, 2025 16:59
@Gustry Gustry added the run end2end If the PR must run end2end tests or not label Jan 13, 2025
Copy link
Contributor

@nworr nworr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, the tail [..] if part is redundant , it can be moved to a zone ?

@Gustry
Copy link
Member Author

Gustry commented Jan 14, 2025

You mean a PHP function to determine the number of line AND a zone for the *.tpl ?

@Gustry
Copy link
Member Author

Gustry commented Jan 14, 2025

@nworr I have added a PHP function for the height of the text area.

I must admit a bit a lazy to create a new class extending jZone, just to generate these 2 "small" textarea, is-it what I'm supposed to do ?

Just some note for myself for testing :

jLog::log('A log in lizmapadmin', 'lizmapadmin');
jLog::log('A log in errors', 'error');
jLog::log('A log in warning', 'warning');
jLog::log('A log in notice', 'notice');
jLog::log('A log in default');

@Gustry Gustry merged commit a4d162e into 3liz:master Jan 15, 2025
16 checks passed
@Gustry Gustry deleted the admin-log branch January 15, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants