Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assets/packages-lock.json after build #5188

Open
wants to merge 1 commit into
base: release_3_8
Choose a base branch
from

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Jan 13, 2025

When building LWC, we have this file updated @nboisteault, is-it normal ?

@Gustry Gustry added the javascript Pull requests that update Javascript code label Jan 13, 2025
@Gustry Gustry requested a review from nboisteault January 13, 2025 13:14
@github-actions github-actions bot added this to the 3.8.5 milestone Jan 13, 2025
@nboisteault
Copy link
Member

I don't have these changes executing npm run build w/ nodejs V20.5.1 and npm 9.8.0. Which versions do you have?

@Gustry Gustry added the run end2end If the PR must run end2end tests or not label Jan 13, 2025
@Gustry
Copy link
Member Author

Gustry commented Jan 14, 2025

I don't have these changes executing npm run build w/ nodejs V20.5.1 and npm 9.8.0. Which versions do you have?

I'm using the docker images, is it not inside ?

I just tried :

git reset --hard
git status
# Build and run LWC using the docker test stack
git status
→ assets/package-lock.json is updated...

Do you do ?

./run-docker build
./run-docker
./lizmap-ctl install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants