-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests - Start Page Object Model for Playwright #5204
Conversation
c01abd1
to
df35032
Compare
Tests should be OK now. @mind84 you review is also welcome (as I can't add you in the GH review list). With this, we avoid "dangerous", not convenient string for coding. Using variables and functions is way more convinient in IDE with autocompletion. It also gives better maintenance for later, when a UI is updated. If merged, please add relevant new locator and function into this class. Let's see later how we do with the "legacy" |
df35032
to
65cca79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use *.js
file instead of *.ts
.
You can add // @ts-check
at the first line to keep the *.ts
file checking
e900ff9
to
f61db60
Compare
f61db60
to
e92bf17
Compare
@rldhont Thanks, it's done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Gustry
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-5204-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 65cca794ddbcf1100652d8def99b6d1e2c24377b,e92bf171cfc7be9af0bb7aa07750c15c903c1613
# Push it to GitHub
git push --set-upstream origin backport-5204-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7 Then, create a pull request where the |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_8 release_3_8
# Navigate to the new working tree
cd .worktrees/backport-release_3_8
# Create a new branch
git switch --create backport-5204-to-release_3_8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 65cca794ddbcf1100652d8def99b6d1e2c24377b,e92bf171cfc7be9af0bb7aa07750c15c903c1613
# Push it to GitHub
git push --set-upstream origin backport-5204-to-release_3_8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_8 Then, create a pull request where the |
Follow up 3liz#5204 Add a way to store and check logs in Project page.
Adding POM : https://playwright.dev/docs/pom
Superseeds #5167