Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests e2e Playwright: Defined global getEchoRequestParams #5223

Merged

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Jan 16, 2025

Method to re-send the request with additionnal echo param to retrieve the OGC Request parameters

@rldhont rldhont added tests unit tests and docker configuration for tests run end2end If the PR must run end2end tests or not backport release_3_7 backport release_3_8 backport release_3_9 labels Jan 16, 2025
@rldhont rldhont requested review from Gustry and nboisteault January 16, 2025 15:48
@github-actions github-actions bot added this to the 3.10.0 milestone Jan 16, 2025
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed nice, after the rephrase idea, LGTM

tests/end2end/playwright/form-filter.spec.js Outdated Show resolved Hide resolved
Method to re-send the request with additionnal echo param to retrieve the OGC Request parameters
@rldhont rldhont force-pushed the tests-e2e-playwright-getEchoRequestParams branch from 1a274b1 to 4a8e14d Compare January 16, 2025 16:39
@rldhont rldhont merged commit 97464e0 into 3liz:master Jan 17, 2025
16 checks passed
@3liz-bot
Copy link
Contributor

The backport to release_3_7 failed:

The process '/usr/bin/git' failed with exit code 1
stderr
error: could not apply 4a8e14d36... Tests e2e Playwright: Defined global getEchoRequestParams
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

stdout
CONFLICT (modify/delete): tests/end2end/playwright/form-filter.spec.js deleted in HEAD and modified in 4a8e14d36 (Tests e2e Playwright: Defined global getEchoRequestParams).  Version 4a8e14d36 (Tests e2e Playwright: Defined global getEchoRequestParams) of tests/end2end/playwright/form-filter.spec.js left in tree.
Auto-merging tests/end2end/playwright/globals.js

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-5223-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 4a8e14d362d2e7b560f12ac9d0800d3049aabfdb
# Push it to GitHub
git push --set-upstream origin backport-5223-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7

Then, create a pull request where the base branch is release_3_7 and the compare/head branch is backport-5223-to-release_3_7.

@3liz-bot
Copy link
Contributor

The backport to release_3_8 failed:

The process '/usr/bin/git' failed with exit code 1
stderr
error: could not apply 4a8e14d36... Tests e2e Playwright: Defined global getEchoRequestParams
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

stdout
CONFLICT (modify/delete): tests/end2end/playwright/form-filter.spec.js deleted in HEAD and modified in 4a8e14d36 (Tests e2e Playwright: Defined global getEchoRequestParams).  Version 4a8e14d36 (Tests e2e Playwright: Defined global getEchoRequestParams) of tests/end2end/playwright/form-filter.spec.js left in tree.

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_8 release_3_8
# Navigate to the new working tree
cd .worktrees/backport-release_3_8
# Create a new branch
git switch --create backport-5223-to-release_3_8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 4a8e14d362d2e7b560f12ac9d0800d3049aabfdb
# Push it to GitHub
git push --set-upstream origin backport-5223-to-release_3_8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_8

Then, create a pull request where the base branch is release_3_8 and the compare/head branch is backport-5223-to-release_3_8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_7 backport release_3_8 backport release_3_9 failed backport run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants