Replace pkg_resources with importlib_resources #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything I can do to get this merged? |
|
As python 3.12 is now the new stable python version and raise a deprecated warning on using pkg_resources api, this merge is really needed |
|
Was about to look into fixing this. Thanks @tvuotila for taking care of it. |
|
Hoping to see this merged soon ... |
|
I'm joining to the crowd waiting this PR merged soon... |
|
Bump |
|
Throw us a Christmas gift @lukasgraf Pretty please :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
Use
importlib.resources.files(usage copied from documentation) instead of deprecatedpkg_resources.resource_string(function documentation).Install
importlib-resourcesbackport package on Python versions less than 3.9 (documentation on how to do that).importlib.resources.fileswas introduced in Python 3.9 (function documentation). Use minimum version of 1.3 forimportlib-resourcespackage as that matches the Python 3.9 (compatibility table)