adding "otherMails" #171
Merged
adding "otherMails" #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2024 09:23
…n no email claim is returned from IdP, and logic to select the first of those returned otherMails as email as last choice
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-wave-082988910-171.centralus.4.azurestaticapps.net |
kirenotneb
approved these changes
Dec 18, 2024
| @@ -21,8 +21,6 @@ export async function findOrCreateUserDetails( | |||
| given_name: true, | |||
| idp: true, | |||
| issuer: true, | |||
| organization: true, | |||
| phone: true, | |||
There was a problem hiding this comment.
Are these causing issues? If not we'd like to collect them if they are provided.
There was a problem hiding this comment.
not causing issues, just not generally returned. I'm content to leave them if you'd prefer
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-wave-082988910-171.centralus.4.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added otherMails claim to b2c policy; when a user's IdP doesn't return an email claim, the user is able to manually specify an email which is retained in the b2c user account in an otherMail attribute. Subsequent logins will not return that email so we must return the otherMails, a string collection, and select the first member of that collection as the email of last resort before an error is generated.