fix(init): Special static_output cases don't work #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code setting RUNMODE was moved too far in 63328d0. First, code checks if RUNMODE is static and only then it sets it to the selected mode. This way special cases when the stdout isn't a terminal or the output fits completely on the screen are not being hit.
|
Thanks for the PR. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code setting RUNMODE was moved too far in 63328d0.
First, code checks if RUNMODE is static and only then it sets it to the selected mode. This way special cases when the stdout isn't a terminal or the output fits completely on the screen are not being hit.