Skip to content
This repository has been archived by the owner on Apr 11, 2022. It is now read-only.

feat: add header with hero section to all project pages #52

Merged
merged 1 commit into from Oct 30, 2021
Merged

feat: add header with hero section to all project pages #52

merged 1 commit into from Oct 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2021

Added a tiny insert of JavaScript so users can be directed to the main point of the pages using jQuery via a scroll animation.

If no JavaScript is allowed it can be removed and the feature could technically still work with out animation.

@ghost ghost mentioned this pull request Oct 29, 2021
@tintinkung
Copy link
Member

If no JavaScript is allowed it can be removed and the feature could technically still work with out animation.

No need to worry, javascript is allowed. its most used language for website anyway

Copy link
Member

@tintinkung tintinkung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Approved

I've previewed the work, nothing is out of place. nice job! the project page is growing alot. 🙇

I'll do a merge big merge to pull request including yours and the 5 PR pending, around 8 AM(UTC) feels free to make some changes

@tintinkung
Copy link
Member

we can keep that issue for later. I dont think it'll have many effect right now
the issue is more on the performance side. fixing it is time consuming. let it be on polishing state

@tintinkung tintinkung added enhancement New feature or request hacktoberfest-accepted accepted for hactoberfest event labels Oct 29, 2021
@ghost
Copy link
Author

ghost commented Oct 29, 2021

✔️ Approved

I've previewed the work, nothing is out of place. nice job! the project page is growing alot. 🙇

I'll do a merge big merge to pull request including yours and the 5 PR pending, at 8 AM(UTC) feels free to make some changes

Awesome, sounds good! 🚀

@tintinkung tintinkung merged commit 7aee42f into ASEAN-Build-The-Earth:main Oct 30, 2021
@tintinkung tintinkung added the status: done this is done / merged label Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request hacktoberfest-accepted accepted for hactoberfest event status: done this is done / merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants