Feature/21 builtin users #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- loading knownUsers objects from config - debug controller (`GET /users`) to test the outcome easily // todo remove
…vider (actually consumes config)
sh: line 1: w: command not found
dk1844
force-pushed
the
feature/21-builtin-users
branch
from
24283a8 to
63c740a
Compare
dk1844
force-pushed
the
feature/21-builtin-users
branch
from
63c740a to
33a239b
Compare
jakipatryk
reviewed
Apr 25, 2023
service/src/main/scala/za/co/absa/logingw/rest/SecurityConfig.scala
Outdated
Show resolved
Hide resolved
service/src/main/scala/za/co/absa/logingw/rest/SecurityConfig.scala
Outdated
Show resolved
Hide resolved
service/src/main/scala/za/co/absa/logingw/rest/config/ConfigValidatable.scala
Outdated
Show resolved
Hide resolved
…pl ConfigValidationError and empty ConfigValidationSuccess). ConfigValidationResult helper methods ( .merge(CVR), .getErrors, ConfigValidationError creation shorthands) ConfigValidatable.validate - does not throw now returns ConfigValidationResult. Implemented a throwing wrapper .failOnValidationError
…onfigValidationResult.validate()) -> ConfigValidationResult.throwOnErrors, ConfigValidationResult.getErrors -> .errors unit tests added/updated
jakipatryk
approved these changes
Apr 26, 2023
# Conflicts: # service/src/main/resources/application.properties
jakipatryk
reviewed
May 2, 2023
jakipatryk
reviewed
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces configuration of the user section where known users can be added (instead of previously built-in) single user.
Configuration redone to YAML in order to properly set list of user details.
Individual configuration classes split - they feature their own validations -- that are run on startup (preventing the application to run if invalid).
Tests added for config classes and the related auth provider.
Closes #21