Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anibel - Personal Portfolio Website - Edges #29

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

anibelamerica
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, I had errors regarding closing elements without their corresponding opening elements. Additionally, I was nesting <li> elements in non-list elements.
Why is it important to consider and use semantic HTML? It is important to practice good semantic HTML to improve user accessibility like in screen readers, etc.
How did you decide to structure your CSS? I made a master style sheet that all pages linked to and then individual CSS sheets for subsequent pages.
What was the most challenging piece of this assignment? The most challenging piece of this assignment was balancing timeline with wanting a "perfect" website. Additionally, I would have an idea but knowing the vocabulary to effectively search for the means to implement was a challenge.
Describe one area that you gained more clarity on when completing this assignment I gained more (and possibly less clarity) on the breadth of resources available, in particular shape transformations. There's a lot out there (maybe too much) but it's useful for learning.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? Stay tuned!
Overall

@tildeee
Copy link

tildeee commented Sep 30, 2018

For this project, the instructors are giving a spot-check review. If you’d like a more in-depth review, please reach out to your instructor!

My review:
Nice work, Anibel! The site meets all of the requirements and the site looks great. Faaaancy CSS stuff going on. I love the collection of puns, too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants