Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scissors - Maria M. #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions heaps/heap_sort.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@

from heaps.min_heap import MinHeap

def heap_sort(list):
""" This method uses a heap to sort an array.
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(n log n)
Space Complexity: O(n)
Comment on lines 3 to +6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice work

"""
pass
heap = MinHeap()
sorted_list = []

for value in list:
heap.add(value)

while heap.store:
sorted_list.append(heap.remove())
return sorted_list
73 changes: 55 additions & 18 deletions heaps/min_heap.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class HeapNode:

def __init__(self, key, value):
self.key = key
self.value = value
Expand All @@ -10,31 +10,57 @@ def __str__(self):
def __repr__(self):
return str(self.value)



class MinHeap:

def __init__(self):
self.store = []

def get_parent(self, index):
return ((index - 1) // 2)

def get_left_child(self, index):
return ((index * 2) + 1)

def get_right_child(self, index):
return ((index * 2) + 2)
Comment on lines +18 to +25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great helper functions


def get_smallest_child(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is a particularly good helper

left_child = self.get_left_child(index)
right_child = self.get_right_child(index)

if left_child < len(self.store):
if right_child >= len(self.store) or (self.store[left_child].key < self.store[right_child].key):
smallest_child = left_child
else:
smallest_child = right_child
return smallest_child

def add(self, key, value = None):
""" This method adds a HeapNode instance to the heap
If value == None the new node's value should be set to key
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(1)
"""
Comment on lines 38 to 43

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
if (value == None):
value = key

node = HeapNode(key, value)
self.store.append(node)
self.heap_up(len(self.store) - 1)

def remove(self):
""" This method removes and returns an element from the heap
maintaining the heap structure
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(1)
"""
Comment on lines 51 to 56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The space complexity is O(log n) due to the recursive call stack.

pass


if len(self.store) == 0:
return None

self.swap(0, len(self.store) - 1)
min = self.store.pop()
self.heap_down(0)
return min.value

def __str__(self):
""" This method lets you print the heap, when you're testing your app.
Expand All @@ -46,10 +72,10 @@ def __str__(self):

def empty(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

""" This method returns true if the heap is empty
Time complexity: ?
Space complexity: ?
Time complexity: O(1)
Space complexity: O(1)
"""
pass
return len(self.store) == 0


def heap_up(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Expand All @@ -59,19 +85,30 @@ def heap_up(self, index):
property is reestablished.

This could be **very** helpful for the add method.
Time complexity: ?
Space complexity: ?
Time complexity: O(log n)
Space complexity: O(1)
"""
pass
while index != 0:
node = self.store[index]
parent_node = self.get_parent(index)

if self.store[parent_node].key > node.key:
self.swap(index, parent_node)
index = parent_node

def heap_down(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

""" This helper method takes an index and
moves the corresponding element down the heap if it's
larger than either of its children and continues until
the heap property is reestablished.
"""
pass
if (index >= len(self.store) - 1):
return
smallest_child = self.get_smallest_child(index)

if smallest_child and self.store[index].key > self.store[smallest_child].key:
self.swap(index, smallest_child)
self.heap_down(smallest_child)

def swap(self, index_1, index_2):
""" Swaps two elements in self.store
Expand Down