Kunzite: Group 5 — Alycia, Barbara, Danqing, Doris #17
Conversation
Adding some scaffolding to avoid conflicts
create get_all_boards route
create new board route
adding add_like route
Add delete card route and update db models
adding tests for patch route
create a route to view all cards and add a nnew card
adding two card routes to board routes, removing them from card_routes
Added tests
Add create route to view single board
testing everything, reorganizing for readability
get rid of incorrect routes for getting and creating cards
Adding delete board route & tests
Clean up code
| "owner": self.owner | ||
| } | ||
| if self.cards: | ||
| board_data["card_count"] = len(self.cards) |
There was a problem hiding this comment.
If all we need is the count of records, rather than using len(), which will retrieve the whole records, only to count them and throw them away, look into ways that SqlAlchemy allows us to specifically only get the count of records.
| if self.board: | ||
| card_data["board_id"] = self.board_id |
There was a problem hiding this comment.
We conditionally included the goal id for task list since it was optional whether a task was part of a goal. Here, we expect all cards to belong to a board (this can even be enforced at a data level by requiring the board id foreign key to be non-null) so we could skip the conditional here.
| new_card = Card( | ||
| message=card_data["message"], | ||
| likes_count=card_data["likes_count"], | ||
| board=validate_model(Board, card_data.get("board_id")) |
There was a problem hiding this comment.
validate_model belongs to the route layer of functionality. It lives in the routes_helper and uses flask functions like abort and make_response. Try to avoid having lower layer types (like the models) depending on higher layer functionality.
| db.session.commit() | ||
|
|
||
|
|
||
| return make_response(jsonify({"card_like_count": card.likes_count}), 200) |
There was a problem hiding this comment.
Prefer to return the entire updated card record. Doing so would allow the front end to replace the entire card record in state without needing to worry about merging the updated data.
No description provided.