Lou, Julie, Mel Site Sapphire #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… snoopy_html_css
Snoopy html css
Added Bowie layout after Julies merge
Created new grid, put picture-nav, put background
First commit after Melindas Merge
Merged txt Bowies facts mod with Mels changes
Refactored code in Bowie.css and updated text box
| @@ -7,7 +7,7 @@ When first starting out, it is common for developers to create a small website t | |||
| We will use HTML & CSS to create a static site whose content is a fansite about something your group is passionate about. Your group fansite should contain a home page with some introductory information about your chosen topic, a fun facts page about your topic, and a gallery showcasing pictures about your topic. | |||
|
|
|||
| ### Sample Site | |||
| View a simple sample website [here](https://adaanswers.github.io/group-fansite-example/index.html). | |||
| View a simple sample website [here](://adaanswers.github.io/group-fansite-example/index.html). https | |||
| </div> | ||
|
|
||
| <div class="gallery"> | ||
| <img src="/images/Keiiko.jpeg" alt="..."> |
There was a problem hiding this comment.
It's a good idea to give your images alt-text so that folks who can't see the images know what's in them!
| <a href="/pages/index.html" id="home">Home</a> | ||
| <a href="/pages/snoopy.html" id="snoopy">Snoopy</a> | ||
| <a href="/pages/Bowie.html" id="bowie">Bowie</a> | ||
| <a href="mailto:[email protected]" id="contact">Contact</a> |
There was a problem hiding this comment.
You could remove this, since it's a fake email.
| <!-- as many times as we want --> | ||
| </div> | ||
| <div class="facts"> | ||
| <h3>I am a floof of the highest degree, an order of FLOOOOFEEE. I enjoy running through the woods and rolling in the stinkiest things that I can find. I am a good mole hunter. My best friend is a chi-hee of the blue variety named Pepper. </h3> |
There was a problem hiding this comment.
This isn't really a heading; it might be better in a p tag.
| <nav class="col-1"> | ||
| <ul> | ||
| <li> | ||
| <h2><a href="index.html">Home</a></h2> |
There was a problem hiding this comment.
Try to use h2 and h3 when you're organizing your content hierarchically. For these, you'd probably have a more accessible page by removing the h2 and h3s and doing the styling with classes on the li elements.
| <h2>The pics!</h2> | ||
| <ul id="gallery"> | ||
| <li> | ||
| <img src="../images/Snoopy/smiling_snoopy.jpeg" alt="fluffy corgi looking up with a smile"> |
|
|
||
| <div class="col-2"> | ||
| <header class="snoopy-header"> | ||
| <h1 id="snoopy-header-text"> |
There was a problem hiding this comment.
This is more like what you want to use h1 for 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.