Maz Weir, Winslow Edwards, Sarah Watkins, Phalesa Patton #41
Conversation
| @@ -0,0 +1,50 @@ | |||
| <html lang="en"> | |||
There was a problem hiding this comment.
Great job creating an additional page
| <header> | ||
| <h1> Real Pictures of the Blue Ridge Mountains</h1> | ||
| <nav> | ||
| <ul> | ||
| <li><a href="index.html">Home</a></li> | ||
| <li><a href="facts.html">Cold Hard Facts</a></li> | ||
| <li><a href="recreation.html">Recreation</a></li> | ||
| <li><a href="gallery.html">Gallery</a></li> | ||
| </ul> | ||
| </nav> | ||
| </header> | ||
| <!--Hiking Pics--> | ||
| <section class="hiking-mod"> | ||
| <h2>Hiking Trails</h2> |
There was a problem hiding this comment.
It's a little subjective, but in this layout I might consider the header and the section as part of the significant content of the page and place it inside a main tag.
| nav ul { | ||
| margin: 0; | ||
| padding: 20px; | ||
| text-align: center; | ||
| list-style-type: none; | ||
| display: flex; | ||
| flex-direction: row; | ||
| flex-wrap: wrap; | ||
| justify-content: center; | ||
| align-items: center; | ||
| gap: 16px; | ||
| } |
There was a problem hiding this comment.
Nice work using this descendant selector
| <li> | ||
| <a href="../pages/index.html">Home</a> | ||
| </li> | ||
| <li> |
There was a problem hiding this comment.
Some list elements have the anchor tag inline and some don't, to make things easy to read and reduce possible confusion, we should pick one and be consistent across the project.
| <body> | ||
| <main class="container"> | ||
| <header class="header"> | ||
| <h1>Blue Ridge Mountains</h1> | ||
| </header> | ||
| <nav class="nav"> | ||
| <ul> | ||
| <li><a href="index.html">Home</a></li> | ||
| <li><a href="facts.html">Cold Hard Facts</a></li> |
There was a problem hiding this comment.
Some indentation is 2-spaces and some is 4-spaces, to make things easy to read and reduce possible confusion, we should pick one and be consistent across the project.
| } | ||
| nav li { |
There was a problem hiding this comment.
I suggest keeping a single blank line between each CSS rule to make it easy to see at a glance where one rule set and an another begins.
No description provided.