Madi Jackson

[dawnsoapp]

Finished adagrams js!

[kelsey-steven-ada]

Nice work on your first solo javascript project 🎉 I've added some questions & comments below, please take a look when you have a moment and reach out here or on Slack if I can clarify anything =]

[kelsey-steven-ada]

Tiny best practices note: The spacing between data structures/functions and indentation isn't consistent across the file, just something to keep in mind to take a look for before opening PRs.

[kelsey-steven-ada]

Great combination of iteration and the spread operator to create the letter pool to draw from.

[kelsey-steven-ada]

There's a bug caused by these lines that I'd like you to try troubleshooting.

What happens if lettersInHand has more than the exact same count of a letter in input, or the letters occur in a different order in lettersInHand than the order in input? I've written a couple tests you can add to the suite to try this out:

    it("returns true when word contains letters in the drawn letters out of order", () => {
      const drawn = ["G", "D", "O", "X", "X", "X", "X", "X", "X", "X"];
      const word = "DOG";

      const isValid = usesAvailableLetters(word, drawn);
      expect(isValid).toBe(true);
    });

    it("returns true when drawn letters contains duplicates of letters in word", () => {
      const drawn = ["D", "O", "G", "G", "X", "X", "X", "X", "X", "X"];
      const word = "DOG";

      const isValid = usesAvailableLetters(word, drawn);
      expect(isValid).toBe(true);
    });

[kelsey-steven-ada]

We could remove the else block here and unindent return false; without changing the function's outcome.

[kelsey-steven-ada]

While javascript allows this syntax, looking at the tests, lettersInHand is an array of strings. To avoid confusion about the kind of data type we're iterating over and remove variables like key that aren't being used, a for-of loop would be a better fit:

for (let letter of lettersInHand) {
...

[kelsey-steven-ada]

We could remove these dictionaries since it looks like they're only referenced in the commented out code.

[kelsey-steven-ada]

In this case we're iterating over a list of words rather than letters, I suggest updating the variable name letter to better reflect what it represents.

[kelsey-steven-ada]

Love the thought to use a frequency map here!

[kelsey-steven-ada]

Since contestants will contain a single word, it's a naming convention to use a singular name like contestant to represent that.

[kelsey-steven-ada]

Small style best practice: we should include a space after a closing brace before any following key words.

[kelsey-steven-ada]

We should prefer using const anywhere we don't need to reassign values - Lists & dictionaries are mutable, we can declare them as const and still add new values, we just then can't re-assign the variable to a new array or dictionary.