Meighan Final TicTacToe #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| // $(document).on('ready', function() { | ||
| // console.log('create and begin the game here!'); | ||
| // var game = new TicTacToe(); |
There was a problem hiding this comment.
I'm curious why you decided to comment this out, it seems like a good plan to me :-)
|
I like the way you separated this out into a few different functions. You did a nice job switching the players and symbols for each turn. I think your win logic is very close to working, it seems like you are focusing more on individual pieces instead of it working for the whole board overall. Looks like you're on a good track! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I have everything working but the win logic. It fails to tell the players when someone has won but does tell them if there is a draw. Something wonky is going on when a click is pushed to my board array.