draft submission for TicTacToe #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue for a particular slot selected
…ch player on each turn
| } | ||
|
|
||
| TicTacToe.prototype.play = function(position, marker) { | ||
| this.turn(); |
There was a problem hiding this comment.
It seems like you would want to switch the players at the end of a turn instead of at the beginning of the turn, right? Will this then end up with player 2 as the first player?
|
Nice job separating everything out into functions. I like the way you've used the turns to determine which player you're on, though I think you could go a step further and use this saved data again. I think if you adjust the parameters you've used in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the click, turn, and player functionality work. However, the won? logic is not getting triggered. The board array is correctly populating with x's and o's based on my game's logic, so I am debugging this section.