Hrw/master #5
Hrw/master #5
Conversation
…reset when they press ok
| html { | ||
|
|
||
| html {} | ||
| .board { margin:1em auto; border-collapse:collapse } |
There was a problem hiding this comment.
I'd recommend keeping your formatting consistent, so I'd write this on multiple lines like you do for your other formatting.
Additionally, and it's not really worth your time unless you really care about it or your team prefers to do it this way, but some people recommend putting the attributes in alphabetical order when possible. Personally, I didn't like to do that on personal projects, and instead grouped them in a way that made sense to me (borders and margins together, width/height together, etc).
|
@wesleywillis, I love the theme that you picked! It's so cool. Most of my feedback were style-guide type issues. Overall, your logic was easy-to-follow, and I didn't struggle with trying to understand what was happening. I asked a couple of prodding questions -- feel free to respond, or not, depending on your time/interest. Let me know if you have any questions, or if there's anything in particular that you wanted me to look at that I didn't comment on! |
| //this.scoreBoard(); | ||
| }; | ||
|
|
||
| TicTacToe.prototype.scoreBoard = function() { |
There was a problem hiding this comment.
I'd consider renaming this function to something more descriptive of what it's doing now. (e.g. findWin or something else)
I have puppy image files in my project that I'm not using yet, but I'm keeping them in there in case I decide to use them when refactoring my code. I would like to make my "X"'s awkward pugs, and my "O"'s corgi friends