Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hannah Cameron - MediaRanker Revisted - Octos #37

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Hannah Cameron - MediaRanker Revisted - Octos #37

wants to merge 28 commits into from

Conversation

hannahlcameron
Copy link

No description provided.

@hannahlcameron
initial setup; starting writing works controller tests. now creating …
3d62312 
…new branch
@hannahlcameron
passing create test: creates a work with valid data for a real category
fcec012
@hannahlcameron
all tests passing for create
4190cda
@hannahlcameron
passing all show tests
c4c2948
@hannahlcameron
passing all update tests
d6fc689
@hannahlcameron
passing all detroy tests
e07c6eb
@hannahlcameron
working on upvote tests
ce010ba
@hannahlcameron
added OmniAuth gem and set up .env file
e965d1f
@hannahlcameron
continuation of adding OmniAuth - changed users model, added amniauth…
835a468 
… to initialization, built create method
@hannahlcameron
added in binding of caller gem
f3d4a20
@hannahlcameron
dried up sessions#create, moved some logic into user model
41399d0
@hannahlcameron
added in OmniAuth initialization, added .env to .gitignore
b24352c
@hannahlcameron
resolved merge conflict
e109c30
@hannahlcameron
removed login_form and deleted login method since using Oauth now
72380cd
@hannahlcameron
wrote out test for upvote
eacaa29
@hannahlcameron
unsaved changes from last session
6bedc13
@hannahlcameron
edit spacing
bd856cc
@hannahlcameron
stubbed out sessions controller tests
b8e1658
@hannahlcameron
no changes
d8651f0
@hannahlcameron
removed duplicate routes in route file, modified login method
9693996
@hannahlcameron
uncommented wave 3 and 4
355f069
@hannahlcameron
merged master with wave 2 in
7d61a22
@hannahlcameron
no changes
5ad7393
@hannahlcameron
edited fixtures to match up with oauth, wrote more upvote tests
8f50f70
@hannahlcameron
merged in sessions testing
d7e05f6
@hannahlcameron
wrote user controller tests, updated rails version in gemfile
41e1329
@hannahlcameron
updated rails version on gemfile, added in tests
58a38d0
@hannahlcameron
added in tests, revised controllers
ddeec57
@kariabancroft
Copy link

MediaRanker Revisted

What We're Looking For

Feature Feedback
General
Appropriate Tests on WorksController Yes - though not voting for a work more than once is a pretty important scenario that you didn't include a test for
Appropriate Tests on SessionsController No
Appropriate Tests on UsersController Yes
Completed OAuth Yes
Overall Works controller tests look good though it seems like you may have shied away from some of the tests that would be harder to write

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahlcameron @kariabancroft