Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mary Ampers #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Mary Ampers #35

wants to merge 3 commits into from

Conversation

mmlamkin
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Most problems I face I think about the solution in Ruby and then try to see if I can solve the problem the same way in JS. This approach is helpful in discovering new methods in javascript that we have not covered in class
What was a challenge you faced in this assignment? I had some issues with scope, for example I had to play around with the tile bag before I was able to access it through the tests and I still don' t think I have the best solution. Debugging is more difficult than with Ruby and I don't feel great about the debugging tool we went over in class, as well. I also constantly forget to add and commit!
Do you have any recommendations on how we could improve this project for the next cohort? I thought it was a good way to show the class how you can adapt our knowledge to learning a new language. It gave me confidence for facing this again. Maybe having a little more debugging skills would have been helpful.

@CheezItMan
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Not Enough Commits! Good commit mesages
Comprehension questions Check, I'm glad you realized the lack of commits. Debugging skills will come with time and practice with JS.
General
score calculates score, has appropriate params and return value Check
highestScoreFrom calculates highest scoring word, has appropriate params and return value Check
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check
Has highestScoringWord and highestWordScore functions Check
Overall Well done, you hit all the major learning goals.

})

let keys = Object.keys(allScores);
let max = Math.max(...keys);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

}

hasWon() {
if (this.totalScore() >= 100) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be:

return this.totalScore() >= 100;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants