Victoria Garcia - Ampers - JS Scrabble #37

Lasiorhine · 2018-05-18T16:04:14Z

JS Scrabble

Congratulations! You're submitting your assignment!

Question	Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript?	Surprisingly few. Conditionals, rough method structure, loops and arrays -- but it feels like there was far more difference than similarity.
What was a challenge you faced in this assignment?	The tests, particularly, felt really impenetrable.
Do you have any recommendations on how we could improve this project for the next cohort?	Uuuh, not really, right now. Too bleary.

…the one about ther bad characters

…ng word method, after reasonable fails.

… how the highestWordScore method is interacting with Score.

…quest time, exclamation point.

CheezItMan · 2018-05-20T02:14:25Z

Feature	Feedback
Core Requirements
Git hygiene	You need a few more commits. Your last commit message had me chuckling.
Comprehension questions	Check, hmmm.. what made the tests impenetrable?
General
`score` calculates score, has appropriate params and return value	Check
`highestScoreFrom` calculates highest scoring word, has appropriate params and return value	Check
`Player` object
Has `name` and `plays` properties	Check
Has `play`, `totalScore`, `hasWon` functions	Chekc
Has `highestScoringWord` and `highestWordScore` functions	Check
Overall	Well done, you hit all the learning goals for the project. I'm sorry you had a tough time of it, but glad you stuck with it.

CheezItMan · 2018-05-20T02:08:41Z

specs/scrabble.spec.js

-
-
+    test('returns false when score < 100', () => {
+      const player = new Scrabble.Player('joe');


It would work better to simply loop through verifying that hashWon returns false from a score of 0 to 99. So you cover the edge cases.

CheezItMan · 2018-05-20T02:11:22Z

specs/scrabble.spec.js

-
-
+    test('returns true when score == 100', () => {
+      const player = new Scrabble.Player('jane');


You want to verify that hasWon is false at 99 and true at 100 and greater.

Lasiorhine added 6 commits May 18, 2018 04:11

Scoring method is written, and all tests for it are passing save for …

457a006

…the one about ther bad characters

Everuthing but the error-driven stuff is passing in the highest scori…

6de483c

…ng word method, after reasonable fails.

all code and tests are written; the tests are not failing in a good way.

0b6f607

down to four failing tests, but I have no idea wth to do asbout them.

eb18c10

down to one failing test, and it's a total puzzler, having to dow tih…

f8d537b

… how the highestWordScore method is interacting with Score.

Good golly, everything's passing with three minutes to spare. Pull re…

3eb6860

…quest time, exclamation point.

CheezItMan reviewed May 20, 2018

View reviewed changes



		test('returns false when score < 100', () => {
		const player = new Scrabble.Player('joe');



		test('returns true when score == 100', () => {
		const player = new Scrabble.Player('jane');