Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Abinnet #40

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Ampers: Abinnet #40

wants to merge 8 commits into from

Conversation

Abiaina
Copy link

@Abiaina Abiaina commented May 18, 2018

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Kind of used my understanding of a class to help create instance methods
What was a challenge you faced in this assignment? Figuring out how to organize my ruby thoughts into JS
Do you have any recommendations on how we could improve this project for the next cohort? I liked the videos, but it would have been nice to have a live code example of a JS project.

@tildeee
Copy link

tildeee commented May 23, 2018

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
score calculates score, has appropriate params and return value x
highestScoreFrom calculates highest scoring word, has appropriate params and return value x
Player object
Has name and plays properties x
Has play, totalScore, hasWon functions x
Has highestScoringWord and highestWordScore functions missing highestWordScore()
Overall

looks like you skipped highestWordScore()?

If I had time to refactor, I would work on refactoring the huge if/else if block in score()

otherwise looks good!

});
}

if (this.hasWon()) return false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even though in JavaScript this works, it is best practice to always have curly braces around a one-line if statement:

if (this.hasWon()) { return false; }

or

if (this.hasWon()) {
  return false;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants