Angela and Jamila - Rideshare Rails - Octos

[knockknockhusthere]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	The driver and passenger classes each have many trips, and each trip has one passenger and one driver.
Describe the role of model validations in your application	In our forms, we checked all values for presence, and checked the vin and phone number for uniqueness as well.
How did your team break up the work to be done?	We paired on setup and business logic, and broke out linking pages, css, and building out page layouts.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized basic functionality and made sure all the pages were accessible. We set aside some edge cases, for example keeping the data if a driver or passenger were deleted
What was one thing that your team collectively gained more clarity on after completing this assignment?	We have more clarity on what needs to modified and where, in order to create and inmplement specific features
What is your Trello URL?	https://trello.com/b/nCyTsZDc/rideshare
What is the Heroku URL of your deployed application?	https://rideshare-app.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	More thinking out loud while we drive. We did good staying on top of our own work, without creating conflicts. We did good at questioning each other, when things weren't clear or didn't make sense yet.

[kariabancroft]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Yes, looks good
Answered comprehension questions	Yes
Uses named routes (like _path)	Yes
RESTful routes utilized	Yes - routes look good
Rideshare Rails Specific Content
Table relationships	Yes - looks good in the schema and model files
Validation rules for Models	Yes - using presence and uniqueness validations
Business logic is in the models	Yes - cost, total and rating logic in model
Database is seeded from the CSV files	Yes - data on Heroku looks good
Trello board is created and utilized in project management	Its not public so I can't tell for sure
Postgres database is used	Yes
Heroku instance is online	Yes
The app is styled to create an attractive user interface	Yes - the tables make it nice and easy to read the data
Overall	You did a nice job hitting the major learning goals of this assignment. One area for improvement is indentation within almost all of the view code. When you use code tags, the contents inside should be indented.

[kariabancroft]

Nice job avoiding the unnecessary instance variable in this controller action

[kariabancroft]

It might be worthwhile to set all of these defaults in a new model method rather than setting them all here

[kariabancroft]

Is there a fancy enumerable method you could use to do this instead?

[kariabancroft]

Watch out for indentation issues here - these are all nested code tags so you'll want to indent every step of the way

[kariabancroft]

Did you run out of time in implementing this feature?