Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Kaitlin #41

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Ampers: Kaitlin #41

wants to merge 7 commits into from

Conversation

kcforsman
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? In class, it seemed to indicate that pieces of code within a program will run without halting the entire program and run in tandem with the rest of the display. (with it you don't need to undergo full requests to change the content on the page)
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? I believe selecting a trip to render the trip details run asynchronously within the page ( as does I believe every dynamic pieces of content within the 1-page app)
What kind of errors might the API give you? How did you choose to handle them? If a trip were not selected, or a name was not given the reservation returns an error. I need to throw a flash message and I think I may have forgotten to handle that....
Do you have any recommendations on how we could improve this project for the next cohort? Not at the moment

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene More commits would be good
Comprehension questions Check
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user No error messages reported
Styling It looks really nice, although it is not responsive.
Under the Hood
Trip data is retrieved using from the API Check
JavaScript is well-organized and easy to read I think it might look a little neater with a bit of white space separating functions, but other than that it's good.
HTML is semantic Check, div elements just used for grouping.
Overall Pretty good, you do need to do something to report errors to the user. That and styling to make it responsive are the things to work on here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants