Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angela and Maja Octos #11

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

Angela and Maja Octos #11

wants to merge 58 commits into from

Conversation

mgraonic
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C9/VideoStoreConsumer-API#9
For each person in your pair, describe something you learned from your partner during this project Maja: Angela showed me how to use a generically named prop to pass in a variety of functions. Angela: I had never previously written a customized validation in a rails model before, and Maja wrote one for movie creation.
What was one area of React you gained more clarity on during this assignment? Passing functions as props through multiple child components. The process of a front-end with React interacting with a separate backend is a lot less intimidating now.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We used one component to render a movie but passed in different props (ie, different functions under a generic prop name like "callBack").
Describe how you handled rentals with React We tracked customer and movie info in the state, then read from the state and made POSt request with axios.
Describe a DOM event your application handled We handled clearing the status messages with a click event that triggered a state change for the Status component (and subsequent rendering) that cleared the last status lingering on screen.
Did you use any functional stateless components? What for? We used stateless components but did not use the functional component syntax.
Did you use any container components? What for? No.
Do you have any recommendations on how we could improve this project for the next cohort? We spent a significant amount of time refactoring the API. And while it was a good learning experience, it did create a lot of confusion. So our recommendation is refactor the code in the wrapper a bit (ie, change how the images are constructed based on how the image url is coming in).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants