Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Daemonize addon store, timeout web requests (nvaccess#16183)
May fix most cases of nvaccess#16123 and nvaccess#16122 Summary of the issue: requests.get has no default timeout, meaning a connection may hang until it is closed by the server. The add-on store uses requests with no timeout to fetch data from the add-on store, and download add-ons. This can cause threads to hang, preventing NVDA from exiting correctly. Update check also has similar risks with usage of urllib like requests. Many threads started in NVDA should also be daemonized. Description of user facing changes NVDA should exit properly in more cases, make installs safer Description of development approach Add timeouts for web requests and daemonize all threads in NVDA.
- Loading branch information