Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title: Fix TypeError in harness.py by updating Coder.create method calls #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bscriver123
Copy link

Pull Request Description:

Description

This pull request addresses the TypeError encountered while running harness.py on swebench-lite. The error was caused by passing an unexpected keyword argument git_dname to Coder.create() which is not present in the latest code on aider-chat.

To resolve this, the pull request modifies the code to remove the git_dname parameter from the call to Coder.create() in harness.py. However, after making this change, another error TypeError: Coder.__init__() got an unexpected keyword argument 'max_chat_history_tokens' occurred. This error is due to passing the max_chat_history_tokens parameter to the Coder constructor, which is also not valid.

This PR aims to fix these issues by updating the parameter passing in the Coder.create() and Coder constructor methods to align with the latest code on aider-chat.

Changes Made

  • Removed the git_dname parameter from the call to Coder.create() in harness.py.
  • Corrected the parameter passing in the Coder constructor to resolve the TypeError: Coder.__init__() got an unexpected keyword argument 'max_chat_history_tokens' error.

Related Issue

Fixes #ISSUE_NUMBER (Replace ISSUE_NUMBER with the actual issue number being addressed)

Please review the changes and provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant