Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unicode support #20

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Added unicode support #20

merged 1 commit into from
Jul 30, 2024

Conversation

zanerock
Copy link
Contributor

This change adds support for unicode support by updating the BNF grammar, parser, and documentation.

Closes #19

@AjaniBilby
Copy link
Owner

This feels wrong, because \uXXXX will only be able to fit up to unicode character 65535, but because JS uses UTF-16 it just works if you use two \u

@AjaniBilby AjaniBilby merged commit 5125d13 into AjaniBilby:main Jul 30, 2024
1 check passed
@AjaniBilby
Copy link
Owner

Published as v4.1.3

@zanerock
Copy link
Contributor Author

Agreed re. \uXXXX feeling wrong; I thought the same thing a few days after committing this. I was thinking I could add an update that supports \u{XXXXXX} syntax as well, which is more natural I think.

@zanerock zanerock deleted the add-unicode-support branch July 30, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unicode support
2 participants
@zanerock @AjaniBilby