Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jaclyn Taroni <[email protected]>
  • Loading branch information
sjspielman and jaclyn-taroni authored Nov 15, 2024
1 parent fb6b488 commit 557c3ea
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ The risk is that the main cell population (in our case the fetal nephron compart

### Summary CNV score

We want to calculate a single CNV score and asesss if/how it can be use to define cells with CNV versus stable/normal cells.
We want to calculate a single CNV score and assess if/how it can be used to define cells with CNV versus stable/normal cells.
We defined the score as described in the [biostar discussion](https://www.biostars.org/p/9573777/).

We would expect:
Expand Down
2 changes: 1 addition & 1 deletion analyses/cell-type-wilms-tumor-06/results/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Based on the above slots, it would be straightforward to extract info of interes

In addition, for the condition `reference = "both"`, we ran `infercnv` with `HMM = TRUE`.
[HMM CNV prediction methods](https://github.com/broadinstitute/infercnv/wiki/inferCNV-HMM-based-CNV-Prediction-Methods) will allow us to explore the CNV results better, with an easy [merge](https://github.com/broadinstitute/infercnv/wiki/Extracting-features) of `infercnv` result with the `Seurat` object.
However, HMM CNV prediction methods uses a lot of resources, including time (~2h/sample/condition), and often casues the R session to crash.
However, HMM CNV prediction methods uses a lot of resources, including time (~2h/sample/condition), and often causes the R session to crash.
This is why we only ran the HMM model for one `reference` condition. After selection of the best reference to use, we will run it for all samples.


Expand Down

0 comments on commit 557c3ea

Please sign in to comment.