Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mkdocs version and fix some link anchors #545

Conversation

sjspielman
Copy link
Member

I recently updated my local version of material-mkdocs, and found that in the current version I have locally, serving the docs found several bad anchor links which had not been flagged previously.

This PR fixes those anchor links and also bumps the mkdocs versions in the docs/requirements.txt file that we use when running the GHA to check links (though maybe I was a bit too prescriptive with the patch version here...). To test if the GHA now flags bad anchor links, I added an intentionally bad one so hopefully the links action fails 🤞

@sjspielman
Copy link
Member Author

This PR has gotten a bit out of hand with all my commit reversions to test whether the mkdocs-material bump is indeed necessary (it is!), so I'm going to close this and open a fresh PR with a cleaner history!

@sjspielman sjspielman closed this Jun 26, 2024
@sjspielman sjspielman deleted the sjspielman/update-mkdocs branch July 11, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant